Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxy): use keepAlive agent #3527

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

matz3
Copy link
Contributor

@matz3 matz3 commented May 25, 2020

Using an agent with keepAlive improves performance as the socket is
reused across multiple requests.

@AppVeyorBot
Copy link

Build karma 2701 completed (commit 6fa29d34f5 by @matz3)

lib/middleware/proxy.js Outdated Show resolved Hide resolved
@karmarunnerbot
Copy link
Member

Build karma 302 completed (commit 6fa29d34f5 by @matz3)

@karmarunnerbot
Copy link
Member

Build karma 303 completed (commit 6fa29d34f5 by @matz3)

@karmarunnerbot
Copy link
Member

Build karma 304 completed (commit e2978de21f by @matz3)

@AppVeyorBot
Copy link

Build karma 2702 completed (commit d60c75b060 by @matz3)

@karmarunnerbot
Copy link
Member

Build karma 303 completed (commit d60c75b060 by @matz3)

@AppVeyorBot
Copy link

Build karma 2703 completed (commit cdae43add2 by @matz3)

@karmarunnerbot
Copy link
Member

Build karma 304 completed (commit 94fb88eaf0 by @matz3)

@karmarunnerbot
Copy link
Member

Build karma 305 completed (commit cdae43add2 by @matz3)

Copy link
Collaborator

@devoto13 devoto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

We already have a E2E test for HTTP proxy here. Ideally we would want to test that proxy connections are re-used, but it may be tricky to implement such test. It should be enough to test that feature itself works correctly + a unit test to verify that correct agent is used.

nit: Consider squashing commits and changing commit to "feat(proxy): ..." as this was not broken before, this is a new feature.

Using an agent with keepAlive improves performance as the socket is
reused across multiple requests.
@matz3
Copy link
Contributor Author

matz3 commented Jun 10, 2020

Thanks for your review! I've squashed the commits and adopted the message.

@AppVeyorBot
Copy link

Build karma 2709 completed (commit ac23b439bb by @matz3)

@karmarunnerbot
Copy link
Member

Build karma 311 completed (commit ac23b439bb by @matz3)

@karmarunnerbot
Copy link
Member

Build karma 310 completed (commit ac23b439bb by @matz3)

@johnjbarton johnjbarton merged commit b77f94c into karma-runner:master Jun 11, 2020
karmarunnerbot pushed a commit that referenced this pull request Jun 11, 2020
# [5.1.0](v5.0.9...v5.1.0) (2020-06-11)

### Features

* **proxy:** use keepAlive agent ([#3527](#3527)) ([b77f94c](b77f94c))
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@matz3 matz3 deleted the proxy-keepAlive-agent branch June 15, 2020 07:25
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
Using an agent with keepAlive improves performance as the socket is
reused across multiple requests.
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
# [5.1.0](karma-runner/karma@v5.0.9...v5.1.0) (2020-06-11)

### Features

* **proxy:** use keepAlive agent ([karma-runner#3527](karma-runner#3527)) ([b77f94c](karma-runner@b77f94c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants